feat: Support startpage.com #19
Conversation
There was a problem hiding this comment.
This change requires an additional permission, https://www.startpage.com.
If a new version of Chrome extension requires an additional permission, Chrome will disable extensions of existing users until they manually re-enable their extensions.
This is a proper behavior for security reasons, but not acceptable to this extension, with a certain number of existing users.
New permissions should not be required by default.
If you really want to add support for startpage.com, you should request a permission for https://startpage.com by chrome.permission.request only when a user explicitly enables support for startpage.com in the options page.
src/manifest.json.js
Outdated
| @@ -248,6 +248,9 @@ const manifest = { | |||
| 'https://www.google.co.zm/search?*', | |||
| 'https://www.google.co.zw/search?*', | |||
| 'https://www.google.cat/search?*', | |||
| 'https://www.startpage.com/do/search*', | |||
There was a problem hiding this comment.
These lines implicitly require a permission for https://www.startpage.com.
DanSnow
force-pushed
the
startpage-support
branch
from
437e0bc
to
5482420
Compare
|
Thanks for reviewing. I have changed it to optional feature. |
|
I'm sorry to be late. |
Hi, thanks for the great work on this extensions.
I have added the supporting for startpage.com.